Skip to content

Bump super-linter from v4 to v7 and fix all files #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2024
Merged

Bump super-linter from v4 to v7 and fix all files #2035

merged 5 commits into from
Oct 10, 2024

Conversation

vinceAmstoutz
Copy link
Contributor

@vinceAmstoutz vinceAmstoutz commented Oct 9, 2024 •
edited
Loading

Solves #1837 by upgrading super-linter from v4 to v7.1.0, upgrade other CI images & fixing files

@vinceAmstoutz vinceAmstoutz force-pushed the build-upgrade-and-fix-super-linter branch 2 times, most recently from 9e4f70e to 820a989 Compare October 9, 2024 12:54
@vinceAmstoutz vinceAmstoutz marked this pull request as draft October 9, 2024 12:55
@vinceAmstoutz vinceAmstoutz marked this pull request as ready for review October 9, 2024 12:55
@vinceAmstoutz vinceAmstoutz force-pushed the build-upgrade-and-fix-super-linter branch 4 times, most recently from 5aecefb to 58c090b Compare October 9, 2024 13:21
@vinceAmstoutz vinceAmstoutz force-pushed the build-upgrade-and-fix-super-linter branch from 58c090b to 6899139 Compare October 9, 2024 13:30
@vinceAmstoutz
feat(lint): enable full codebase validation in CI
53cefc8 
Changed the VALIDATE_ALL_CODEBASE environment variable from false to true (default value) in the GitHub Actions CI workflow. This ensures that the linter checks the entire codebase rather than only changes, potentially catching more issues.
@vinceAmstoutz vinceAmstoutz force-pushed the build-upgrade-and-fix-super-linter branch 4 times, most recently from 09f5184 to fffbaa8 Compare October 9, 2024 17:04
@vinceAmstoutz vinceAmstoutz force-pushed the build-upgrade-and-fix-super-linter branch from fffbaa8 to 493303a Compare October 9, 2024 17:07
@vinceAmstoutz
chore(linter): disable MARKDOWN_PRETTIER to resolve conflicts
bbe0067 
Disabled MARKDOWN_PRETTIER to avoid conflicts with markdownlint.
@vinceAmstoutz
Copy link
Contributor Author

To avoid a conflict between the MARKDOWN and MARKDOWN_PRETTIER linters, we can either disable specific rules that conflict in the linter configurations, or disable one of the 2 linters. I chose the 2nd option because MARKDOWN_PRETTIER didn't exist before (introduced since v6, we'd stayed with v4)), I then deactivated it. What do you think? @soyuka @dunglas

@vinceAmstoutz vinceAmstoutz requested review from dunglas and soyuka and removed request for dunglas October 9, 2024 20:01
@vinceAmstoutz vinceAmstoutz changed the title Bump super-linter and fix all files Bump super-linter from v4 to v7 and fix all files Oct 9, 2024
@dunglas dunglas merged commit d879647 into api-platform:4.0 Oct 10, 2024
1 check passed
@dunglas
Copy link
Member

dunglas commented Oct 10, 2024

Thank you very much!!

@vinceAmstoutz vinceAmstoutz deleted the build-upgrade-and-fix-super-linter branch October 10, 2024 05:41
@vinceAmstoutz vinceAmstoutz mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka Awaiting requested review from soyuka

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinceAmstoutz @dunglas